Ticket #11285: auto_create_log_directory.diff

activesupport/test/buffered_logger_test.rb

@@ -104 +104 @@
-    @logger.info 'there it is.'
-    assert !@output.string.empty?, @output.string
-  end
+  
+  def test_should_create_the_log_directory_if_it_doesnt_exist
+    tmp_directory = File.join(File.dirname(__FILE__), "tmp")
+    log_file = File.join(tmp_directory, "development.log")
+    assert !File.exist?(tmp_directory)
+    @logger  = ActiveSupport::BufferedLogger.new(log_file)
+    assert File.exist?(tmp_directory)
+  ensure
+    FileUtils.rm_rf(tmp_directory)
+  end
-end

activesupport/lib/active_support/buffered_logger.rb

@@ -47 +47 @@
-        @log = open(log, (File::WRONLY | File::APPEND))
-        @log.sync = true
-      else
+        FileUtils.mkdir_p(File.dirname(log))
-        @log = open(log, (File::WRONLY | File::APPEND | File::CREAT))
-        @log.sync = true
-        @log.write("# Logfile created on %s" % [Time.now.to_s])

railties/lib/initializer.rb

@@ -255 +255 @@
-            logger.auto_flushing = false
-            logger.set_non_blocking_io
-          end
-
+ 
-          logger = ActiveSupport::BufferedLogger.new(STDERR)
-          logger.level = ActiveSupport::BufferedLogger::WARN
-          logger.warn(