Ticket #11156: add_readonly_option_to_has_many_through_associations.diff

test/models/author.rb

@@ -20 +20 @@
-  has_many :funky_comments, :through => :posts, :source => :comments
-  has_many :ordered_uniq_comments, :through => :posts, :source => :comments, :uniq => true, :order => 'comments.id'
-  has_many :ordered_uniq_comments_desc, :through => :posts, :source => :comments, :uniq => true, :order => 'comments.id DESC'
-
+
+
-  has_many :special_posts
-  has_many :special_post_comments, :through => :special_posts, :source => :comments
-

test/cases/associations_test.rb

@@ -554 +554 @@
-    companies(:first_firm).readonly_clients.find(:all).each { |c| assert c.readonly? }
-  end
-
+  def test_cant_save_has_many_readonly_association
+    authors(:david).readonly_comments.each { |c| assert_raise(ActiveRecord::ReadOnlyRecord) { c.save! } }
+    authors(:david).readonly_comments.each { |c| assert c.readonly? }
+  end
+
-  def test_triple_equality
-    assert !(Array === Firm.find(:first).clients)
-    assert Firm.find(:first).clients === Array

lib/active_record/associations/has_many_through_association.rb

@@ -145 +145 @@
-            :order      => @reflection.options[:order],
-            :limit      => @reflection.options[:limit],
-            :group      => @reflection.options[:group],
+            :readonly   => @reflection.options[:readonly],
-            :include    => @reflection.options[:include] || @reflection.source_reflection.options[:include]
-          )
-
@@ -239 +240 @@
-                         :include     => @reflection.options[:include],
-                         :select      => construct_select,
-                         :order       => @reflection.options[:order],
-
+
+
+
-        end
-
-        def construct_sql