Ticket #11084: add_readonly_option_to_has_many_associations.diff

test/models/company.rb

@@ -40 +40 @@
-           :counter_sql => 'SELECT COUNT(*) FROM companies WHERE client_of = 1000'
-  has_many :clients_using_finder_sql, :class_name => "Client", :finder_sql => 'SELECT * FROM companies WHERE 1=1'
-  has_many :plain_clients, :class_name => 'Client'
+  has_many :readonly_clients, :class_name => 'Client', :readonly => true
-
-  has_one :account, :foreign_key => "firm_id", :dependent => :destroy
-end

test/cases/reflection_test.rb

@@ -159 +159 @@
-  end
-
-  def test_reflection_of_all_associations
-7
-5
+8
+6
-    assert_equal 2, Firm.reflect_on_all_associations(:has_one).size
-    assert_equal 0, Firm.reflect_on_all_associations(:belongs_to).size
-  end

test/cases/associations_test.rb

@@ -544 +544 @@
-    assert_equal 2, companies(:first_firm).limited_clients.find_all_by_type('Client', :limit => 9_000).length
-  end
-
+  def test_dynamic_find_all_should_respect_readonly_access
+    companies(:first_firm).readonly_clients.find(:all).each { |c| assert_raise(ActiveRecord::ReadOnlyRecord) { c.save  } }
+    companies(:first_firm).readonly_clients.find(:all).each { |c| assert c.readonly? }
+  end
+
-  def test_triple_equality
-    assert !(Array === Firm.find(:first).clients)
-    assert Firm.find(:first).clients === Array

lib/active_record/associations/association_proxy.rb

@@ -114 +114 @@
-            :offset  => @reflection.options[:offset],
-            :joins   => @reflection.options[:joins],
-            :include => @reflection.options[:include],
-
+
+
-          )
-        end
-

lib/active_record/associations.rb

@@ -669 +669 @@
-      # * <tt>:source_type</tt>: Specifies type of the source association used by <tt>has_many :through</tt> queries where the source
-      #   association is a polymorphic +belongs_to+.
-      # * <tt>:uniq</tt> - if set to +true+, duplicates will be omitted from the collection. Useful in conjunction with <tt>:through</tt>.
+      # * <tt>:readonly</tt> - if set to +true+, all the associated objects are readonly through the association. Default is +false+.
-      #
-      # Option examples:
-      #   has_many :comments, :order => "posted_on"
@@ -677 +678 @@
-      #   has_many :tracks, :order => "position", :dependent => :destroy
-      #   has_many :comments, :dependent => :nullify
-      #   has_many :tags, :as => :taggable
+      #   has_many :reports, :readonly => true
-      #   has_many :subscribers, :through => :subscriptions, :source => :user
-      #   has_many :subscribers, :class_name => "Person", :finder_sql =>
-      #       'SELECT DISTINCT people.* ' +
@@ -1234 +1236 @@
-            :uniq,
-            :finder_sql, :counter_sql,
-            :before_add, :after_add, :before_remove, :after_remove,
-
+, :readonly
-          )
-
-          options[:extend] = create_extension_modules(association_id, extension, options[:extend])