Ticket #10806: add_quantity_option_to_increment_counter_and_decrement_counter_for_consistency_with_absolute.diff

test/base_test.rb

@@ -559 +559 @@
-
-    Topic.increment_counter("replies_count", 1)
-    assert_equal 3, Topic.find(1).replies_count
+    
+    Topic.increment_counter("replies_count", 1, 2)
+    assert_equal 5, Topic.find(1).replies_count
-  end
-  
-  def test_decrement_counter
@@ -567 +570 @@
-
-    Topic.decrement_counter("replies_count", 2)
-    assert_equal -2, Topic.find(2).replies_count
+
+    Topic.decrement_counter("replies_count", 2, 2)
+    assert_equal -4, Topic.find(2).replies_count
-  end
-
-  def test_update_all

lib/active_record/base.rb

@@ -781 +781 @@
-      #
-      # +counter_name+  The name of the field that should be incremented
-      # +id+            The id of the object that should be incremented
+      # +by+            The amount by which to increment the column value (default is 1)
-      #
-      # ==== Examples
-      #
-      #   # Increment the post_count column for the record with an id of 5
-      #   DiscussionBoard.increment_counter(:post_count, 5)
-
-1
+, by = 1
+by.to_i.abs
-      end
-
-      # Decrement a number field by one, usually representing a count.
@@ -798 +799 @@
-      #
-      # +counter_name+  The name of the field that should be decremented
-      # +id+            The id of the object that should be decremented
+      # +by+            The amount by which to decrement the column value (default is 1)
-      #
-      # ==== Examples
-      #
-      #   # Decrement the post_count column for the record with an id of 5
-      #   DiscussionBoard.decrement_counter(:post_count, 5)
-
-1
+, by = 1
+(by.to_i.abs)
-      end
-
-