Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #10595: Object.isNumber_and_Object.isString.diff

File Object.isNumber_and_Object.isString.diff, 1.3 kB (added by foca, 7 months ago)
  • test/unit/base.html

    old new  
    340340    testObjectIsString: function() { with(this) { 
    341341      assert(!Object.isString(function() { })); 
    342342      assert(Object.isString("a string")); 
     343      assert(Object.isString(new String("something"))); 
    343344      assert(!Object.isString(0)); 
    344345      assert(!Object.isString([])); 
    345346      assert(!Object.isString({})); 
     
    350351    testObjectIsNumber: function() { with(this) { 
    351352      assert(Object.isNumber(0)); 
    352353      assert(Object.isNumber(1.0)); 
     354      assert(Object.isNumber(new Number(1))); 
    353355      assert(!Object.isNumber(function() { })); 
    354356      assert(!Object.isNumber("a string")); 
    355357      assert(!Object.isNumber([])); 
  • src/base.js

    old new  
    144144  }, 
    145145   
    146146  isString: function(object) { 
    147     return typeof object == "string"
     147    return typeof object == "string" || object instanceof String
    148148  }, 
    149149   
    150150  isNumber: function(object) { 
    151     return typeof object == "number"
     151    return typeof object == "number" || object instanceof Number
    152152  }, 
    153153   
    154154  isUndefined: function(object) {